Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require at least tokio 1.26.0 #166

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Conversation

JoeHut
Copy link
Contributor

@JoeHut JoeHut commented Nov 9, 2023

buffrs uses tokio::fs::try_exists which was only added in tokio v1.26.0.

Not pinning it might result in compilation errors if buffrs is used programmatically in projects with a lower tokio version dependency.

buffrs uses [tokio::fs::try_exists](https://docs.rs/tokio/1.26.0/tokio/fs/fn.try_exists.html)
which was only added in tokio v1.26.0.

Not pinning it might result in compilation errors if buffrs is used
programmatically in projects with a lower tokio version dependency.
@JoeHut JoeHut requested a review from mara-schulke November 9, 2023 15:06
@JoeHut JoeHut self-assigned this Nov 9, 2023
@mara-schulke mara-schulke merged commit 7774884 into helsing-ai:main Nov 9, 2023
@mara-schulke mara-schulke added complexity::low Issues or ideas with a low implementation cost component::cli Everything related to the buffrs cli priority::high Urgent change or idea, please review quickly type::fix labels Nov 9, 2023
@mara-schulke mara-schulke added this to the User Experience milestone Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
complexity::low Issues or ideas with a low implementation cost component::cli Everything related to the buffrs cli priority::high Urgent change or idea, please review quickly type::fix
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants